Code style tweaks

panghou · Jul 4, 2018 · 18e020f · 18e020f
1 parent 9c64d84
commit 18e020f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 18 deletions.
diff --git a/lib/msnodesqlv8.js b/lib/msnodesqlv8.js
@@ -10,7 +10,7 @@ const UDT = require('./udt').PARSERS
 const DECLARATIONS = require('./datatypes').DECLARATIONS
 const ISOLATION_LEVEL = require('./isolationlevel')
 
-const EMPTY_BUFFER = new Buffer(0)
+const EMPTY_BUFFER = Buffer.alloc(0)
 const JSON_COLUMN_ID = 'JSON_F52E2B61-18A1-11d1-B105-00805F49916B'
 const XML_COLUMN_ID = 'XML_F52E2B61-18A1-11d1-B105-00805F49916B'
 
@@ -81,7 +81,7 @@ const castParameter = function (value, type) {
     case TYPES.VarBinary:
     case TYPES.Image:
       if (!(value instanceof Buffer)) {
-        value = new Buffer(value.toString())
+        value = Buffer.from(value.toString())
       }
       break
     case TYPES.TVP:

diff --git a/test/common/tests.js b/test/common/tests.js
@@ -184,7 +184,7 @@ module.exports = (sql, driver) => {
     },
 
     'binary data' (done) {
-      const sample = new Buffer([0x00, 0x01, 0xe2, 0x40])
+      const sample = Buffer.from([0x00, 0x01, 0xe2, 0x40])
 
       const req = new TestRequest()
       req.input('in', sql.Binary, sample)
@@ -231,20 +231,6 @@ module.exports = (sql, driver) => {
       }).catch(done)
     },
 
-    'domain' (done) {
-      let d = require('domain').create()
-      d.run(function () {
-        const req = new TestRequest()
-        let domain = process.domain
-
-        req.query('', function (err, recordset) {
-          assert.strictEqual(domain, process.domain)
-
-          done(err)
-        })
-      })
-    },
-
     'empty query' (done) {
       const req = new TestRequest()
       req.query('').then(result => {
@@ -290,7 +276,7 @@ module.exports = (sql, driver) => {
     },
 
     'query with input parameters' (mode, done) {
-      const buff = new Buffer([0x00, 0x01, 0xe2, 0x40])
+      const buff = Buffer.from([0x00, 0x01, 0xe2, 0x40])
 
       const req = new sql.Request()
       req.input('id', 12)