Skip to content

Commit

Permalink
internal/runtime/maps: re-enable some tests
Browse files Browse the repository at this point in the history
Re-enable tests for stack-allocated maps and fast map accessors.
Those are implemented now.

Update golang#54766

Change-Id: I8c019702bd9fb077b2fe3f7c78e8e9e10d2263a6
Reviewed-on: https://go-review.googlesource.com/c/go/+/642376
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>
Auto-Submit: Keith Randall <[email protected]>
  • Loading branch information
randall77 authored and gopherbot committed Jan 14, 2025
1 parent befc436 commit c5e205e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion src/internal/runtime/maps/map_swiss_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ func TestTableGroupCount(t *testing.T) {
var testCases = []struct {
n int // n is the number of map elements
escape mapCase // expected values for escaping map
// TODO(go.dev/issue/54766): implement stack allocated maps
}{
{
n: -(1 << 30),
Expand Down
4 changes: 0 additions & 4 deletions src/runtime/map_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -674,10 +674,6 @@ func TestIgnoreBogusMapHint(t *testing.T) {
var testNonEscapingMapVariable int = 8

func TestNonEscapingMap(t *testing.T) {
if goexperiment.SwissMap {
t.Skip("TODO(go.dev/issue/54766): implement stack allocated maps")
}

n := testing.AllocsPerRun(1000, func() {
m := map[int]int{}
m[0] = 0
Expand Down
5 changes: 0 additions & 5 deletions test/codegen/maps.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// TODO(#54766): Temporarily disable for swissmap, which have fast variants
// disabled. This test expects fast variants.
//
//go:build !goexperiment.swissmap

package codegen

// This file contains code generation tests related to the handling of
Expand Down

0 comments on commit c5e205e

Please sign in to comment.