Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make writeSnapshot atomic for watchman backend #175

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Try to make writeSnapshot atomic for watchman backend #175

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e36eb50
Try to make writeSnapshot atomic for watchman backend
yamadapc May 28, 2024
c313651
Add manual calls to flush and close (though the destructor should do it)
yamadapc May 28, 2024
99abe49
Update to write to a sibling file rather than a tmp one
yamadapc May 28, 2024
c254d7f
Use temporary file approach instead
yamadapc May 28, 2024
1e68eb4
Fix typo in snapshot write
yamadapc May 28, 2024
75df0ac
Fix typo
yamadapc May 28, 2024
4408782
Raise test timeouts
pyamada-atlassian May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in snapshot write
  • Loading branch information
@yamadapc
yamadapc committed May 28, 2024
commit 1e68eb4af3d7c2b4b1e9b94b99d9cd882bbba142
2 changes: 1 addition & 1 deletion src/watchman/WatchmanBackend.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ void WatchmanBackend::writeSnapshot(Watcher &watcher, std::string *snapshotPath)
auto temporaryDirectory = std::filesystem::temp_directory_path();
auto temporaryFilePath = temporaryDirectory.append("tmp-parcel-snapshot.txt");
{
std::ofstream ofs(*snapshotPath);
std::ofstream ofs(*temporaryFilePath);
ofs << clockValue;
ofs.flush();
ofs.close();
Expand Down
Loading