Merge pull request rails#142 from sunaku/subquery

to_sql: add support for emitting SQL subqueries
parkerl · Sep 23, 2012 · 08d034a · 08d034a
2 parents e032dab + c001fad
commit 08d034a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/arel/visitors/to_sql.rb b/lib/arel/visitors/to_sql.rb
@@ -254,6 +254,10 @@ def visit_Arel_Nodes_Grouping o
         "(#{visit o.expr})"
       end
 
+      def visit_Arel_SelectManager o
+        "(#{o.to_sql.rstrip})"
+      end
+
       def visit_Arel_Nodes_Ascending o
         "#{visit o.expr} ASC"
       end

diff --git a/test/visitors/test_to_sql.rb b/test/visitors/test_to_sql.rb
@@ -126,6 +126,11 @@ def dispatch
         @visitor.accept(nil).must_be_like "NULL"
       end
 
+      it "should visit_Arel_SelectManager, which is a subquery" do
+        mgr = Table.new(:foo).project(:bar)
+        @visitor.accept(mgr).must_be_like '(SELECT bar FROM "foo")'
+      end
+
       it "should visit_Arel_Nodes_And" do
         node = Nodes::And.new [@attr.eq(10), @attr.eq(11)]
         @visitor.accept(node).must_be_like %{