Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and Travis CI #10

Merged
merged 13 commits into from
Jan 11, 2018
Merged

Add tests and Travis CI #10

merged 13 commits into from
Jan 11, 2018

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jan 2, 2018

Hi!

I have written a small test suite with py.test and added the necessary files for enabling Travis CI automated testing. That way any future forks and PRs can check quickly if they are breaking something or not. The main repo should be enabled https://travis-ci.org/, but other than that, it's pretty much pre-configured.

I did this because I am thinking of a deeper PR (current development here ), but that's another discussion :)

Let me know what you think!

@jaimergp
Copy link
Contributor Author

jaimergp commented Jan 2, 2018

First commit 9ccd2cf can be ignored. It's from a previous attempt and somehow reappeared here.

@bobbypaton bobbypaton merged commit b5e5171 into patonlab:master Jan 11, 2018
@jaimergp
Copy link
Contributor Author

Hi, thanks for the merge!
For this to be functional, you have to sync your GitHub account at https://travis-ci.org and enable this repository. After that, you would probably want to edit the README.md so the Travis badge points to https://travis-ci.org/bobbypaton/GoodVibes instead of my fork.
Once that's done, any further PRs and commits will benefit from the automated testing in Travis :)

@bobbypaton
Copy link
Member

Many thanks for this - looks like this is now working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants