DAOS-14194 common: Address admem coverity issues (daos-stack#12866)

CID 1347806 integer overflow CID 1347807 storage leak Signed-off-by: Jeff Olivier <[email protected]>
paul356 · Aug 21, 2023 · 8318e93 · 8318e93
1 parent 8693f2c
commit 8318e93
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/common/ad_mem.c b/src/common/ad_mem.c
@@ -1476,7 +1476,7 @@ arena_addr2grp(struct ad_arena *arena, daos_off_t addr, struct ad_group **grp_p)
 			return -DER_INVAL;
 		}
 
-		size = gd->gd_unit_nr * gd->gd_unit;
+		size = (daos_size_t)gd->gd_unit_nr * gd->gd_unit;
 		if (gd->gd_addr <= addr && gd->gd_addr + size > addr) {
 			found = true;
 			break;
@@ -2001,6 +2001,7 @@ arena_reserve_grp(struct ad_arena *arena, daos_size_t size, int *pos,
 	/* run out of ad groups */
 	if (grp_idx == ARENA_GRP_MAX) {
 		D_DEBUG(DB_TRACE, "Arena=%d, no group found\n", arena2id(arena));
+		arena_decref(arena);
 		return -DER_NOSPACE;
 	}
 	arena->ar_last_grp = max(arena->ar_last_grp, grp_idx);