Code style

paulbalomiri · Feb 14, 2015 · d8634e0 · d8634e0
1 parent 04151aa
commit d8634e0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/tools/test-utils.js b/tools/test-utils.js
@@ -1,5 +1,3 @@
-var _ = require('underscore');
-var release = require('./release.js');
 var isopackets = require("./isopackets.js");
 var config = require('./config.js');
 var utils = require('./utils.js');
@@ -170,7 +168,7 @@ exports.createOrganization = function (username, password) {
   var orgName = exports.randomOrgName();
   auth.withAccountsConnection(function (conn) {
     try {
-      var result = conn.call("login", {
+      conn.call("login", {
         meteorAccountsLoginInfo: { username: username, password: password },
         clientInfo: {}
       });

diff --git a/tools/tropohouse.js b/tools/tropohouse.js
@@ -198,7 +198,7 @@ _.extend(exports.Tropohouse.prototype, {
         var rest = latestMeteorSymlink.substr(
           packagesDirectoryName.length + files.pathSep.length);
 
-        var pieces = rest.split(files.pathSep);
+        pieces = rest.split(files.pathSep);
         latestToolPackageEscaped = pieces[0];
         latestToolVersion = pieces[1];
       }
@@ -271,7 +271,6 @@ _.extend(exports.Tropohouse.prototype, {
   //
   // XXX: Error handling.
   _downloadBuildToTempDir: function (versionInfo, buildRecord) {
-    var self = this;
     var url = buildRecord.build.url;
 
     // XXX: We use one progress for download & untar; this isn't ideal:
@@ -505,14 +504,15 @@ _.extend(exports.Tropohouse.prototype, {
     options = options || {};
     var serverArchs = options.serverArchitectures || [archinfo.host()];
 
+    var downloader;
     var downloaders = [];
     packageMap.eachPackage(function (packageName, info) {
       if (info.kind !== 'versioned')
         return;
       buildmessage.enterJob(
         "checking for " + packageName + "@" + info.version,
         function () {
-          var downloader = self._makeDownloader({
+          downloader = self._makeDownloader({
             packageName: packageName,
             version: info.version,
             architectures: serverArchs
@@ -537,7 +537,7 @@ _.extend(exports.Tropohouse.prototype, {
 
     // Just one package to download? Use a good message.
     if (downloaders.length === 1) {
-      var downloader = downloaders[0];
+      downloader = downloaders[0];
       buildmessage.enterJob(
         "downloading " + downloader.packageName + "@" + downloader.version,
         function () {

diff --git a/tools/updater.js b/tools/updater.js
@@ -36,7 +36,7 @@ var firstCheck = true;
 var checkForUpdate = function (showBanner, printErrors) {
   // While we're doing background stuff, try to revoke any old tokens in our
   // session file.
-  auth.tryRevokeOldTokens({timeout: 15*1000});
+  auth.tryRevokeOldTokens({ timeout: 15 * 1000 });
 
   if (firstCheck) {
     // We want to avoid a potential race condition here, because we run an