Fixed WidgetModality's initialization logic to always run.

If a widget was not constructed with `{modal: true}`, WidgetModality's initialization logic would not run, which is wrong, and it is now fixed. Also, the initialization logic has moved from the constructor function to the `initializer` method. Fixes #2531401
paulorcf · Nov 10, 2011 · 73a4612 · 73a4612
1 parent 6d4eb1e
commit 73a4612
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/src/widget-modality/js/Widget-Modality.js b/src/widget-modality/js/Widget-Modality.js
@@ -52,19 +52,7 @@ var WIDGET       = 'widget',
      * @class WidgetModality
      * @param {Object} config User configuration object
      */
-    function WidgetModal(config) {
-        if (config && config.modal) {
-            Y.after(this._renderUIModal, this, RENDER_UI);
-            Y.after(this._syncUIModal, this, SYNC_UI);
-            Y.after(this._bindUIModal, this, BIND_UI);
-
-            if (this.get('rendered')) {
-                this._renderUIModal();
-                this._syncUIModal();
-                this._bindUIModal();
-            }
-        }
-    }
+    function WidgetModal(config) {}
 
     var MODAL           = 'modal',
         MASK            = 'mask',
@@ -197,6 +185,16 @@ var WIDGET       = 'widget',
 
     WidgetModal.prototype = {
 
+        initializer: function () {
+            Y.after(this._renderUIModal, this, RENDER_UI);
+            Y.after(this._syncUIModal, this, SYNC_UI);
+            Y.after(this._bindUIModal, this, BIND_UI);
+        },
+
+        destructor: function () {
+            this._detachUIHandlesModal();
+        },
+
         // *** Instance Members *** //
 
         _maskNode   : WidgetModal._GET_MASK(),