[pull] master from faif:master #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Add more type hints
It makes more sense to pass the `move` object to the `do_action()` method instead of having to initialize a `Person` instance with an `Action` object.
…pattern Add Protocol to factory pattern
Pass the `move` object to the `do_action()` method
…criptor class to decorator method
…ces, changed to multiline string
#415 linter preventing prs
Before diving into any of the patterns, readers should be reminded of two fundamental laws in software architecture: 1.Everything is a trade-ff 2."Why is more important than the how" So, readers face the nuances and reality of these patterns from the beginning. These two laws are coined by two thought leaders in software architecture: Mark Richards and Neal Ford. They have explained these two laws in various conference talks and books. For example, Here you can read about these two laws here: https://www.infoq.com/podcasts/software-architecture-hard-parts/ Also, here is a book for reference: https://a.co/d/fKOodW9
Update README.md
Added routing
Lint sh cleanup
Remove mutable.ai references
- It's required to capture the args/kwargs when called at run time. - Fix doctest output to include hints
Highlight the need for a wrapper in delegate
- Changed __init__ in AbstractExpert to abstract method - Added comments
Abstract factory fixes
* Removed old Python versions * Removed 3.10 from tox and upgraded requirements-dev.txt becasue of higher versions in lint.sh * 3.13 changed to 3.12 * Adjusted lint_python workflow Upgraded flake8 to 7.1 * Added continue-on-error: true. So that if the workflow stop comes in error, it will continue. * Added workflow to check per PR * Moved workflow * Changed name workflow * Changed job name * Added approval for non-Python files and removed continue-on-error * Optimzed lint_pr.yml * Added fix for PyTest * Let pytest only test on changed python design patterns * Optimized Tox * Allow tox execute it's checks * Tox optimization 2 * Optimized check * Ignore setup.py from linting unless it is changes * Fixed bug * Testing a idea * Revert idea * added __init__.py to tests/ for tox * Let tox only test on Python files that are in the PR. * Adjusted .coveragerc * added usedevelop = true to tox.ini * Change cov from patterns to main * Rewrote check. * retry fixing coverage * Change cov to main * Added coverage run to execute pytest * changed cov to patterns * created pyproject.toml and moved old config to backup folder * Testing * Changed opts to doctest * Fix for error Unknown config option: randomly_seed * Trying fix for No data was collected. (no-data-collected) * Changed source from patterns to ./ * Changed source from patterns to ./
* Removed old Python versions * Added typing * Fixed bug * Removed bugs and added more types * Fixed bug on check if controller is defined * removed object definition from routes * I fixed a bug * Ädded comments and lost types * Fixed types for Router * Fixed lines * yeah sure * List dammit! * . * oops * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )