-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add custom filter #5
Conversation
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, small changes needed.
src/models/txs_filter.rs
Outdated
} | ||
} | ||
} | ||
|
||
impl FromStr for PriceQuery { | ||
impl FromStr for GasPriceQuery { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please dont' rename it, you can use PriceQuery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, then keep it PriceQuery
src/models/txs_filter.rs
Outdated
pub real_tx_cost: Option<PriceQuery>, | ||
pub gas_price: Option<PriceQuery>, | ||
pub real_gas_price: Option<PriceQuery>, | ||
pub tx_cost: Option<TxCostQuery>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@darkhorse-solution thank you! |
Add custom filter for tx-cost, real-gas-cost... as le0.5ether, ge100gwei