Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add custom filter #5

Merged
merged 3 commits into from
Mar 24, 2025
Merged

Conversation

darkhorse-solution
Copy link
Contributor

Add custom filter for tx-cost, real-gas-cost... as le0.5ether, ge100gwei

@darkhorse-solution
Copy link
Contributor Author

Done.
Please review it

Copy link
Owner

@pawurb pawurb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, small changes needed.

}
}
}

impl FromStr for PriceQuery {
impl FromStr for GasPriceQuery {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont' rename it, you can use PriceQuery

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then keep it PriceQuery

pub real_tx_cost: Option<PriceQuery>,
pub gas_price: Option<PriceQuery>,
pub real_gas_price: Option<PriceQuery>,
pub tx_cost: Option<TxCostQuery>,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@pawurb pawurb merged commit e0d41d1 into pawurb:main Mar 24, 2025
4 checks passed
@pawurb
Copy link
Owner

pawurb commented Mar 24, 2025

@darkhorse-solution thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants