Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Commit

Permalink
docs: update EMOTION_MIGRATION.md (#427)
Browse files Browse the repository at this point in the history
* Update EMOTION_MIGRATION.md

add some additional gotchas we ran into while migrating Mineral UI

* Update EMOTION_MIGRATION.md

remove invalid style array guidelines
  • Loading branch information
coldpour authored and Kent C. Dodds committed Jun 6, 2018
1 parent 5136e84 commit 747df62
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions other/EMOTION_MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ SomeComponent.defaultProps = {

```

### Simulation of Pseudo Selectors

Emotion doesn't support simulation of pseudo selectors. Glamor creates additional styles for `[data-simulate-*]` selectors in dev mode. Remove any `[data-simulate-*]` selectors that you still have in your styles and any calls to `glamor.simulate`.

### Prop Filtering

Emotion's prop filtering only looks at attributes that are valid for all DOM elements, whereas Glamorous uses the tag to determine which attributes are valid.

## Possible Gotchas

This list is not comprehensive please feel free to make adjustments or additions.
Expand Down

0 comments on commit 747df62

Please sign in to comment.