Skip to content

Commit

Permalink
Remove Uniqued<Base>
Browse files Browse the repository at this point in the history
This type was one of the prototypes for `OrderedSet` — it allowed us to customize the collection type used for element storage. (E.g., using `Deque` instead of `Array` to get efficient insertions at the front.) The original idea was that `OrderedSet` would simply be a typealias:

```swift
typealias OrderedSet<Element> = Uniqued<Array<Element>>
```

Unfortunately, while this concept is intellectually pleasing, in practice it just made the interface more complicated (and, in some cases, slower). Worse, it cannot be directly translated to an `OrderedDictionary`-style key-value mapping without major usability problems.

# Conflicts:
#	Package.swift
  • Loading branch information
lorentey committed Apr 5, 2021
1 parent a2bcac4 commit 6860968
Show file tree
Hide file tree
Showing 33 changed files with 0 additions and 6,186 deletions.
78 changes: 0 additions & 78 deletions .swiftpm/xcode/xcshareddata/xcschemes/UniquedModule.xcscheme

This file was deleted.

11 changes: 0 additions & 11 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ let package = Package(
.library(name: "Collections", targets: ["Collections"]),
.library(name: "DequeModule", targets: ["DequeModule"]),
.library(name: "OrderedCollections", targets: ["OrderedCollections"]),
.library(name: "UniquedModule", targets: ["UniquedModule"]),

.executable(name: "swift-collections-benchmark", targets: ["swift-collections-benchmark"]),
],
Expand Down Expand Up @@ -126,16 +125,6 @@ let package = Package(
name: "OrderedCollectionsTests",
dependencies: ["OrderedCollections", "CollectionsTestSupport"],
swiftSettings: settings),

// Uniqued<Base>
.target(
name: "UniquedModule",
dependencies: ["DequeModule"],
swiftSettings: settings),
.testTarget(
name: "UniquedTests",
dependencies: ["UniquedModule", "CollectionsTestSupport"],
swiftSettings: settings),
],
cxxLanguageStandard: .cxx1z
)
27 changes: 0 additions & 27 deletions Sources/UniquedModule/RandomAccessCollection+Offsets.swift

This file was deleted.

51 changes: 0 additions & 51 deletions Sources/UniquedModule/Uniqued+Codable.swift

This file was deleted.

38 changes: 0 additions & 38 deletions Sources/UniquedModule/Uniqued+CustomDebugStringConvertible.swift

This file was deleted.

16 changes: 0 additions & 16 deletions Sources/UniquedModule/Uniqued+CustomReflectable.swift

This file was deleted.

27 changes: 0 additions & 27 deletions Sources/UniquedModule/Uniqued+CustomStringConvertible.swift

This file was deleted.

16 changes: 0 additions & 16 deletions Sources/UniquedModule/Uniqued+Equatable.swift

This file was deleted.

20 changes: 0 additions & 20 deletions Sources/UniquedModule/Uniqued+ExpressibleByArrayLiteral.swift

This file was deleted.

19 changes: 0 additions & 19 deletions Sources/UniquedModule/Uniqued+Hashable.swift

This file was deleted.

53 changes: 0 additions & 53 deletions Sources/UniquedModule/Uniqued+Initializers.swift

This file was deleted.

Loading

0 comments on commit 6860968

Please sign in to comment.