Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add folly build #10

Merged
merged 4 commits into from
Nov 12, 2024
Merged

feat: add folly build #10

merged 4 commits into from
Nov 12, 2024

Conversation

devillove084
Copy link
Contributor

No description provided.

@devillove084 devillove084 reopened this Nov 3, 2024
@devillove084 devillove084 force-pushed the feat/ci_add_folly_build branch from db79e3d to 8f82cbb Compare November 3, 2024 06:52
Xuanwo
Xuanwo reviewed Nov 3, 2024
View reviewed changes
.cargo/config.toml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
cxx-async/Cargo.toml Outdated Show resolved Hide resolved
cxx-async/build.rs Show resolved Hide resolved
@Xuanwo
Copy link
Collaborator

Xuanwo commented Nov 3, 2024

Thank you @devillove084 a lot for working on this!

@devillove084 devillove084 force-pushed the feat/ci_add_folly_build branch from 8f82cbb to 41ba39e Compare November 9, 2024 09:31
@devillove084
Copy link
Contributor Author

  • All compiled objects here have temporarily fixed versions, but in the future there may be symbol resolution problems caused by other factors, such as the superposition of dependencies;
  • Currently, libstdc++ is used as C++ implementation;
  • Because the author did not deal with the library search other than the system path when dealing with related folly and boost parsing issues, this issue will be left to the future for now;

I will continue to pay attention to and maintain the fragile compilation requirements and relationships here. If anyone have any questions in the future, feel free to @ me

@Xuanwo I am very grateful for the opportunity to deeply understand the coroutine mechanism of the two languages. I am honored.

@devillove084 devillove084 force-pushed the feat/ci_add_folly_build branch from 41ba39e to 74afbfc Compare November 9, 2024 09:46
Xuanwo
Xuanwo approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @devillove084 for working on this, really great!

@Xuanwo Xuanwo merged commit 4b59755 into pcwalton:main Nov 12, 2024
2 checks passed
@Xuanwo Xuanwo mentioned this pull request Nov 12, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devillove084 @Xuanwo