Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "other" field to Page #196

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Add "other" field to Page #196

merged 3 commits into from
Sep 21, 2023

Conversation

frankfralick
Copy link
Contributor

This PR adds a field called "other" to Page, enabling access to the various optional entries that can be present. This also adds an example "other_page_content" as well as an example file to use with it "example_annotation.pdf" that demonstrates finding text that has been struck through.

@s3bk s3bk merged commit 2426717 into pdf-rs:master Sep 21, 2023
@s3bk
Copy link
Contributor

s3bk commented Sep 21, 2023

I think Annots should be added as a field later. But for now this will work just fine.

@frankfralick
Copy link
Contributor Author

Thanks. I will hopefully be at a point in the next month where I'm going to need to deal with a much broader set of the annotation types than I currently do. If you are open to it I would like to add a field for it and type similar to how Resources is. Before I do a lot of work I will show you what I'd propose on Zulip. Also, do you have any idea when you might publish a new version of this repo to crates.io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants