Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrongly typed checksum field in EmbeddedFileParamDict #238

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

lSoleyl
Copy link
Contributor

@lSoleyl lSoleyl commented Nov 11, 2024

Fix for resolver().get() failing with following error when resolving a Ref<Stream<EmbeddedFile>>, if a CheckSum field is present:

Shared, caused by
  Can't parse field params of struct Option < EmbeddedFileParamDict >, caused by
  Can't parse field checksum of struct Option < Date >, caused by
  Failed parsing date

ChekSum is defined as 16-byte string, so PdfString should be a more fitting type.

@s3bk s3bk merged commit b69e075 into pdf-rs:master Nov 15, 2024
@s3bk
Copy link
Contributor

s3bk commented Nov 15, 2024

Yea, to be honest I am not sure how that ended up being a date. It just makes no sense. I may have done that by accident when converting lots of dates from string to date.

@lSoleyl lSoleyl deleted the fix_ef_checksum_type branch November 20, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants