PG-1467 Add clang builds to CI

[artemgavrilov]

https://perconadev.atlassian.net/browse/PG-1467

[jeltz]

What feature from a more modern Meson did you need? That would be useful information to have in the commit message if someone sees this in the future and wonders why it is installed from pip.

[artemgavrilov]

What feature from a more modern Meson did you need? That would be useful information to have in the commit message if someone sees this in the future and wonders why it is installed from pip.

Old version of meson incorrectly checks existence of some libs/funcs/structs available in a system. That caused compilation failure due name collision. While update helped to solve original issue and compile project there are still differences between gcc and clang builds.

You can check and compare output of these two commands:
CC=gcc meson setup build --prefix build-gcc --buildtype=debug -Dcassert=true -Dtap_tests=enabled CC=clang meson setup build --prefix build-clang --buildtype=debug -Dcassert=true -Dtap_tests=enabled`

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.94%. Comparing base (fd43ead) to head (338e53f).

❌ Your project status has failed because the head coverage (78.94%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@                Coverage Diff                 @@
##           TDE_REL_17_STABLE     #230   +/-   ##
==================================================
  Coverage              78.93%   78.94%           
==================================================
  Files                     22       22           
  Lines                   2464     2465    +1     
  Branches                 385      386    +1     
==================================================
+ Hits                    1945     1946    +1     
  Misses                   444      444           
  Partials                  75       75           

Components	Coverage Δ
access	81.54% <ø> (ø)
catalog	86.32% <ø> (ø)
common	92.50% <ø> (ø)
encryption	71.90% <ø> (ø)
keyring	72.07% <ø> (ø)
src	55.73% <ø> (ø)
smgr	98.03% <ø> (+0.01%)	⬆️
transam	∅ <ø> (∅)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dutow]

This isn't correct, but maybe it works because we are only using C files. But it should be g++ or clang++

[artemgavrilov]

You right, even though both compilers can automatically switch mode based on file extensions they still have differences against what stdlib program will be linked. However the only C++ code that we have is demos in libkmip and we don't compile it at all. So I will just drop CXX variable here.

[AndersAstrand]

Looks great!

Weirdly it seems to wait for results of ci runs that no longer exists?

[artemgavrilov]

Weirdly it seems to wait for results of ci runs that no longer exists?

They are marked as required in repo settings, so before merging it should be updated.

[AndersAstrand]

Weirdly it seems to wait for results of ci runs that no longer exists?

They are marked as required in repo settings, so before merging it should be updated.

Do we need to get IT helpdesk involved to do that or does anyone in the team have the proper access?

[artemgavrilov]

Weirdly it seems to wait for results of ci runs that no longer exists?

They are marked as required in repo settings, so before merging it should be updated.

Do we need to get IT helpdesk involved to do that or does anyone in the team have the proper access?

@dutow has admin permissions in the repo