Skip to content

Make ALTER TABLE ... SET ACCESS METHOD logic easier to read #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented Apr 25, 2025

This also cleans up the tests and adds a couple of tests for the DEFAULT which I wanted myself to avoid regressions when doing this refactor.

This removes some unnecessary queries and formats the queries to be
easier to read.
@jeltz jeltz requested review from dutow and dAdAbird as code owners April 25, 2025 09:51
Also add a couple of tests for the DEFAULT case to avoid regressions.
@jeltz jeltz force-pushed the tde/alter-access-meth-cleanup branch from e051cd7 to d118b58 Compare April 25, 2025 09:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (57ac8c8) to head (d118b58).

❌ Your project status has failed because the head coverage (78.12%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #257      +/-   ##
=====================================================
- Coverage              78.13%   78.12%   -0.01%     
=====================================================
  Files                     22       22              
  Lines                   2488     2487       -1     
  Branches                 393      393              
=====================================================
- Hits                    1944     1943       -1     
  Misses                   466      466              
  Partials                  78       78              
Components Coverage Δ
access 78.67% <ø> (ø)
catalog 86.06% <ø> (ø)
common 92.50% <ø> (ø)
encryption 71.90% <ø> (ø)
keyring 72.07% <ø> (ø)
src 53.64% <100.00%> (-0.16%) ⬇️
smgr 98.01% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz merged commit dffece7 into percona:TDE_REL_17_STABLE Apr 28, 2025
22 checks passed
@jeltz jeltz deleted the tde/alter-access-meth-cleanup branch April 28, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants