PG-1537 Error on required arguments #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (78.36%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #267 +/- ##
=====================================================
+ Coverage 78.34% 78.36% +0.02%
=====================================================
Files 22 22
Lines 2484 2482 -2
Branches 391 393 +2
=====================================================
- Hits 1946 1945 -1
+ Misses 462 461 -1
Partials 76 76
🚀 New features to boost your workflow:
|
Sort declarations and visually separate static functions from user facing functions.
Seems like these should belong in the same file as the functions for creating and modifying these entries.
Move the argument parsing to the _internal function so validation only have to be done there.
We should reject both null and the empty string in many of our user facing functions.
Previously these simply crashed the server on NULL input, require these parameters to be non-null, and also do not accept the empty string.
Passing NULL here crashed the server. Also do not accept the empty string.
AndersAstrand
force-pushed
the
tde/validate-input-in-user-functions
branch
from
3f5fb21 to
ddd2519
Compare
jeltz
requested changes
Apr 25, 2025
|
|
||
| if (!PG_ARGISNULL(arg_num)) | ||
| { | ||
| value = text_to_cstring(PG_GETARG_TEXT_PP(arg_num)); |
There was a problem hiding this comment.
Shouldn't we have a separate error message for this, e.g. like the below?
# SELECT * FROM pg_create_physical_replication_slot('');
ERROR: replication slot name "" is too short
There was a problem hiding this comment.
I'm not sure I see the value in that. But we can if we want to! :)
If we do that we should probably only do it when creating stuff and accept the empty string (and never find anything) when looking things up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not accept NULL or the empty string for required arguments in our user facing functions.
I'm a bit unsure of where the helper
required_text_argument()belongs, any input is appreciated.