PG-1537 Error on required arguments #267
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (79.50%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #267 +/- ##
=====================================================
+ Coverage 79.38% 79.50% +0.11%
=====================================================
Files 22 22
Lines 2532 2537 +5
Branches 396 400 +4
=====================================================
+ Hits 2010 2017 +7
+ Misses 444 443 -1
+ Partials 78 77 -1
🚀 New features to boost your workflow:
|
AndersAstrand
force-pushed
the
tde/validate-input-in-user-functions
branch
from
3f5fb21 to
ddd2519
Compare
|
|
||
| if (!PG_ARGISNULL(arg_num)) | ||
| { | ||
| value = text_to_cstring(PG_GETARG_TEXT_PP(arg_num)); |
There was a problem hiding this comment.
Shouldn't we have a separate error message for this, e.g. like the below?
# SELECT * FROM pg_create_physical_replication_slot('');
ERROR: replication slot name "" is too short
There was a problem hiding this comment.
I'm not sure I see the value in that. But we can if we want to! :)
If we do that we should probably only do it when creating stuff and accept the empty string (and never find anything) when looking things up.
There was a problem hiding this comment.
I think I do prefer that since it is after all a plugin which will be used by anyone.
There was a problem hiding this comment.
New version of the branch pushed, please take a look. I think this is better.
AndersAstrand
force-pushed
the
tde/validate-input-in-user-functions
branch
from
ddd2519 to
8539c49
Compare
Passing NULL here crashed the server, also do not accept the empty string as a key name.
Previously these simply crashed the server on NULL input.
Also update the error message for too long provider names to make it symmetrical.
AndersAstrand
force-pushed
the
tde/validate-input-in-user-functions
branch
from
8539c49 to
7261edf
Compare
Do not accept NULL or the empty string for required arguments in our user facing functions.
I'm a bit unsure of where the helper
required_text_argument()belongs, any input is appreciated.