Skip to content

Clean up some switch statements and if chains #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented Apr 26, 2025

In tde_keyring.c we do a lot of switching on the keyring type, some of it which could be done in a slightly nicer way.

In tde_keyring.c we do a lot of switching on the keyring type, some of
it which could be done in a slightly nicer way.
@jeltz jeltz requested review from dutow and dAdAbird as code owners April 26, 2025 08:43
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (e355f38) to head (0220117).

❌ Your project status has failed because the head coverage (78.42%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #273      +/-   ##
=====================================================
+ Coverage              78.34%   78.42%   +0.08%     
=====================================================
  Files                     22       22              
  Lines                   2484     2480       -4     
  Branches                 391      388       -3     
=====================================================
- Hits                    1946     1945       -1     
+ Misses                   462      459       -3     
  Partials                  76       76              
Components Coverage Δ
access 79.35% <ø> (ø)
catalog 86.51% <40.00%> (+0.27%) ⬆️
common 92.50% <ø> (ø)
encryption 71.90% <ø> (ø)
keyring 72.07% <ø> (ø)
src 53.79% <ø> (ø)
smgr 98.01% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz merged commit 712dcf5 into percona:TDE_REL_17_STABLE Apr 28, 2025
15 checks passed
@jeltz jeltz deleted the tde/clean-switches branch April 28, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants