Skip to content

PG-1667 Validate Vault engine type #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: TDE_REL_17_STABLE
Choose a base branch
from

Conversation

artemgavrilov
Copy link
Collaborator

@artemgavrilov artemgavrilov force-pushed the PG-1667-validate-valut-engine-type branch 2 times, most recently from c33da4a to 04a2a01 Compare July 4, 2025 17:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.13924% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (7dff5d0) to head (04a2a01).

❌ Your project status has failed because the head coverage (84.83%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #462      +/-   ##
=====================================================
+ Coverage              84.68%   84.83%   +0.14%     
=====================================================
  Files                     21       21              
  Lines                   2593     2671      +78     
  Branches                 401      411      +10     
=====================================================
+ Hits                    2196     2266      +70     
- Misses                   316      323       +7     
- Partials                  81       82       +1     
Components Coverage Δ
access 81.11% <ø> (ø)
catalog 88.22% <ø> (ø)
common 77.77% <ø> (ø)
encryption 73.45% <ø> (ø)
keyring 75.56% <91.13%> (+2.67%) ⬆️
src 91.54% <ø> (ø)
smgr 94.85% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pg_tde supports only Key/Value version 2 engine type for Hashicorp
Vault. Add validation for that by quering mountpoint metadata.
@artemgavrilov artemgavrilov force-pushed the PG-1667-validate-valut-engine-type branch from 04a2a01 to c45dc70 Compare July 4, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants