Change the file name of the wal keys to match better #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other keys are stored in <oid>_keys so wal_keys fits better into that pattern than the more redundant wal_encryption_keys where "encryption" does not add any information but just makes the path longer.
dAdAbird
approved these changes
Aug 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (82.03%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #504 +/- ##
==================================================
Coverage 82.03% 82.03%
==================================================
Files 25 25
Lines 3168 3168
Branches 514 514
==================================================
Hits 2599 2599
Misses 460 460
Partials 109 109
🚀 New features to boost your workflow:
|
|
That was intentional to make the distinction between the two types of key files overly visible. I have no strong opinion either way however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other keys are stored in
<oid>_keyssowal_keysfits better into that pattern than the more redundant wal_encryption_keys where "encryption" does not add any information but just makes the path longer.A bit bikshedding but this PR was quick to write.