Split the type enum for WAL key and SMGR key types #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltz
changed the title
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (82.21%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #510 +/- ##
=====================================================
+ Coverage 82.00% 82.21% +0.21%
=====================================================
Files 24 25 +1
Lines 3162 3177 +15
Branches 514 515 +1
=====================================================
+ Hits 2593 2612 +19
+ Misses 460 456 -4
Partials 109 109
🚀 New features to boost your workflow:
|
dutow
approved these changes
Aug 7, 2025
jeltz
force-pushed
the
tde/clean-key-file-split-status
branch
from
f39f465 to
3c1a426
Compare
dAdAbird
approved these changes
Aug 8, 2025
Sincw we never delete WAL keys this logic only confuses the reader of the code. Plus we can optimize the insertion of a new WAL key by using seek().
Let's stop pretending that we support more than two status: empty or that there is a SMGR key.
Also rename enum variants for consistency plus renumber the types for the WAL keys which is fine since this file is newly introduced which makes breaking backwards compatibility not an issue.
jeltz
force-pushed
the
tde/clean-key-file-split-status
branch
from
3c1a426 to
95ded59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since they used no common types at all (with a small exception of empty being used in the WAL code but not WAL file) it makes a lot of sense to split the two enums. Additionally we clean up the code a bit and introduce a minor performance improvement when generating a new WAL key.