Skip to content

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented Aug 10, 2025

Some of the functions which take a principal key should take a const pointer.

@AndersAstrand
Copy link
Collaborator

s/Consitify/Constify/
s/fucntions/functions/

Some of the functions which take a principal key should take a const
pointer.
@jeltz jeltz force-pushed the tde/constify-arguments branch from 1355e6c to 54f7079 Compare August 11, 2025 14:15
@jeltz jeltz changed the title Consitify some function arguments Constify some function arguments Aug 11, 2025
@jeltz
Copy link
Collaborator Author

jeltz commented Aug 11, 2025

Fixed!

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.20%. Comparing base (da899e0) to head (54f7079).
⚠️ Report is 5 commits behind head on TDE_REL_17_STABLE.

❌ Your project status has failed because the head coverage (82.20%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #518      +/-   ##
=====================================================
- Coverage              82.22%   82.20%   -0.03%     
=====================================================
  Files                     25       25              
  Lines                   3179     3175       -4     
  Branches                 515      515              
=====================================================
- Hits                    2614     2610       -4     
  Misses                   456      456              
  Partials                 109      109              
Components Coverage Δ
access 83.47% <75.00%> (-0.10%) ⬇️
catalog 87.61% <ø> (ø)
common 77.77% <ø> (ø)
encryption 72.97% <ø> (ø)
keyring 73.21% <ø> (ø)
src 94.15% <ø> (ø)
smgr 95.29% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz merged commit 3d90419 into percona:TDE_REL_17_STABLE Aug 11, 2025
19 checks passed
@jeltz jeltz deleted the tde/constify-arguments branch August 19, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants