PG-1862 Use system() over exec() for archive/restore commands #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's decrypt, not deceypt.
|
EDIT: I was missing something. |
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (82.07%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #526 +/- ##
=====================================================
- Coverage 82.19% 82.07% -0.13%
=====================================================
Files 25 25
Lines 3174 3168 -6
Branches 515 504 -11
=====================================================
- Hits 2609 2600 -9
- Misses 456 461 +5
+ Partials 109 107 -2
🚀 New features to boost your workflow:
|
AndersAstrand
force-pushed
the
tde/use-system-for-archiving
branch
2 times, most recently
from
0924dc5 to
81fea7b
Compare
AndersAstrand
changed the title
AndersAstrand
force-pushed
the
tde/use-system-for-archiving
branch
2 times, most recently
from
7a825ad to
f074219
Compare
Use a single argument for the wrapped command in the archivation wrappers. Instead of giving all of the arguments of the command separately and trying to figure out which one should be replaced by the path to the unencrypted WAL segment, we take a single argument and do % parameter replacement similar to what postgres does with archive_command and restore_command. This also mean that we can simplify by using system() instead of exec(). We also clean up usage instructions and make the two wrappers more symmetrical by requiring the same parameters. Co-authored-by: Andreas Karlsson <[email protected]>
AndersAstrand
force-pushed
the
tde/use-system-for-archiving
branch
from
f074219 to
423d614
Compare
AndersAstrand
merged commit f508287
into
percona:TDE_REL_17_STABLE
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single argument for the wrapped command in the archivation wrappers.
Instead of giving all of the arguments of the command separately and trying to figure out which one should be replaced by the path to the unencrypted WAL segment, we take a single argument and do % parameter replacement similar to what postgres does with archive_command and restore_command.
This also mean that we can simplify by using system() instead of exec().
Replaces: #522
https://perconadev.atlassian.net/browse/PG-1862