Skip to content

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented Aug 14, 2025

To not break recovery when we replay encrypted WAL but WAL encryption is disabled the simplest way is to treat disabled WAL encryption just like enabled WAL encryption. The issue is not big in practice since it should only hit users who disable WAL encryption and then crash the database but treating both cases the same way makes the code simple to understand.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.50%. Comparing base (9dfed22) to head (d2857e1).

❌ Your project status has failed because the head coverage (82.50%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #536      +/-   ##
=====================================================
- Coverage              82.51%   82.50%   -0.02%     
=====================================================
  Files                     25       25              
  Lines                   3209     3207       -2     
  Branches                 510      508       -2     
=====================================================
- Hits                    2648     2646       -2     
  Misses                   452      452              
  Partials                 109      109              
Components Coverage Δ
access 84.91% <100.00%> (-0.05%) ⬇️
catalog 87.68% <ø> (ø)
common 77.77% <ø> (ø)
encryption 72.97% <ø> (ø)
keyring 73.21% <ø> (ø)
src 94.15% <ø> (ø)
smgr 96.53% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz force-pushed the tde/unecrypted-old-keys-writes branch from 04c7d22 to cc5d80a Compare August 14, 2025 18:21
To not break recovery when we replay encrypted WAL but WAL encryption is
disabled the simplest way is to treat disabled WAL encryption just like
enabled WAL encryption. The issue is not big in practice since it should
only hit users who disable WAL encryption and then crash the database
but treating both cases the same way makes the code simple to
understand.
@jeltz jeltz force-pushed the tde/unecrypted-old-keys-writes branch from cc5d80a to 6f92f97 Compare August 14, 2025 18:34
We make sure to delete the keyring files before running the test.
@jeltz jeltz force-pushed the tde/unecrypted-old-keys-writes branch from 6f92f97 to d2857e1 Compare August 14, 2025 18:35
@jeltz jeltz merged commit 167aef2 into percona:TDE_REL_17_STABLE Aug 14, 2025
18 of 19 checks passed
@jeltz jeltz deleted the tde/unecrypted-old-keys-writes branch August 19, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants