Feature/prepared perfco #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 18, 2019 09:49
gtbX
requested changes
Oct 22, 2019
src/SQLiteAsync.cs
Outdated
| /// </summary> | ||
| public void Dispose() | ||
| { | ||
| Dispose(true); |
There was a problem hiding this comment.
Since Inner already handles finalizing the statement, you don't need to muck about with this pattern. Just public void Dispose() => Inner.Dispose(); and drop the protected version in this class
added 2 commits
October 22, 2019 15:39
gtbX
reviewed
Oct 22, 2019
| public class SQLitePreparedStatement : IDisposable { | ||
| Sqlite3Statement Statement; | ||
| SQLiteConnection Connection { get; set; } | ||
| SQLiteConnection Connection { get; set; } |
There was a problem hiding this comment.
isn't the whole thing private by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.