Skip to content

Commit

Permalink
udev: drop useless --mount argument to ceph-disk
Browse files Browse the repository at this point in the history
It doesn't mean anything anymore; drop it.

Signed-off-by: Sage Weil <[email protected]>
  • Loading branch information
Sage Weil committed Jun 14, 2013
1 parent b139152 commit bcfd2f3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/ceph-disk-udev
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ case $ID_PART_ENTRY_TYPE in
4fbd7e29-9d25-41b8-afd0-062c0ceff05d)
# OSD_UUID
# activate ceph-tagged partitions.
/usr/sbin/ceph-disk -v activate --mount /dev/${NAME}
/usr/sbin/ceph-disk -v activate /dev/${NAME}
;;

4fbd7e29-9d25-41b8-afd0-5ec00ceff05d)
Expand All @@ -38,7 +38,7 @@ case $ID_PART_ENTRY_TYPE in
ID_PART_ENTRY_UUID=$(/usr/sbin/sgdisk --info=${PARTNO} /dev/${PARENT_NAME} | grep "Partition unique GUID" | awk '{print $4}' | tr '[:upper:]' '[:lower:]')
/sbin/cryptsetup --key-file /etc/ceph/dmcrypt-keys/${ID_PART_ENTRY_UUID} --key-size 256 create ${ID_PART_ENTRY_UUID} /dev/${NAME}
bash -c 'while [ ! -e /dev/mapper/${ID_PART_ENTRY_UUID} ];do sleep 1; done'
/usr/sbin/ceph-disk-activate --mount /dev/mapper/${ID_PART_ENTRY_UUID}
/usr/sbin/ceph-disk-activate /dev/mapper/${ID_PART_ENTRY_UUID}
;;

89c57f98-2fe5-4dc0-89c1-f3ad0ceff2be)
Expand Down
4 changes: 2 additions & 2 deletions udev/95-ceph-osd.rules
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
ACTION=="add", SUBSYSTEM=="block", \
ENV{DEVTYPE}=="partition", \
ENV{ID_PART_ENTRY_TYPE}=="4fbd7e29-9d25-41b8-afd0-062c0ceff05d", \
RUN+="/usr/sbin/ceph-disk-activate --mount /dev/$name"
RUN+="/usr/sbin/ceph-disk-activate /dev/$name"

# activate ceph-tagged partitions
ACTION=="add", SUBSYSTEM=="block", \
Expand All @@ -24,4 +24,4 @@ ACTION=="add" SUBSYSTEM=="block", \
ENV{ID_PART_ENTRY_TYPE}=="4fbd7e29-9d25-41b8-afd0-5ec00ceff05d", \
RUN+="/sbin/cryptsetup --key-file /etc/ceph/dmcrypt-keys/$env{ID_PART_ENTRY_UUID} --key-size 256 create $env{ID_PART_ENTRY_UUID} /dev/$name", \
RUN+="/bin/bash -c 'while [ ! -e /dev/mapper/$env{ID_PART_ENTRY_UUID} ];do sleep 1; done'", \
RUN+="/usr/sbin/ceph-disk-activate --mount /dev/mapper/$env{ID_PART_ENTRY_UUID}"
RUN+="/usr/sbin/ceph-disk-activate /dev/mapper/$env{ID_PART_ENTRY_UUID}"

0 comments on commit bcfd2f3

Please sign in to comment.