when countable is not implemented, it is probably better to return 0

petrosppg · Jul 8, 2022 · 6d0ee21 · 6d0ee21
1 parent 3709bac
commit 6d0ee21
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/zend/base.cpp b/zend/base.cpp
@@ -274,7 +274,7 @@ Php::Value Base::__count(Php::Parameters &params)
     auto *countable = dynamic_cast<Countable*>(this);
 
     // this one should not fail
-    if (countable == nullptr) return -1;
+    if (countable == nullptr) return 0;
 
     // pass the call to the interface
     return countable->count();