Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor locking to use an ILockService provider #179

Merged
merged 10 commits into from
Feb 27, 2025

Conversation

dviry
Copy link
Collaborator

@dviry dviry commented Feb 27, 2025

Motivation

Implements #178

Passes WOPI-Validation tests for Locks:

Test group: Locks
  Pass: LockLengthValidation
  Pass: LockFormatValidation
  Pass: SuccessfulLockSequence
  Pass: LockMismatchAfterUnlockAndRelockRequest
  Pass: DoubleLockSequence
  Pass: UnlockUnlockedFile
  Pass: LockMismatchOnLockRequest
  Pass: LockMismatchOnUnlockRequest
  Pass: LockMismatchOnRefreshLockRequest
  Pass: LockMismatchOnUnlockAndRelockRequest
  Pass: LockMismatchOnPutFileRequest
  Pass: LockFileWithInvalidAccessToken
  Pass: UnlockFileWithInvalidAccessToken

@dviry dviry requested a review from petrsvihlik as a code owner February 27, 2025 15:35
@codefactor-io codefactor-io bot temporarily deployed to Integrate Pull Request February 27, 2025 15:35 Inactive
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 33.81295% with 92 lines in your changes missing coverage. Please review.

Project coverage is 23.26%. Comparing base (f83208d) to head (f95d6f1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/WopiHost.Core/Controllers/FilesController.cs 27.05% 47 Missing and 15 partials ⚠️
...c/WopiHost.Core/Controllers/EcosystemController.cs 0.00% 10 Missing ⚠️
...Core/Security/Authentication/AccessTokenHandler.cs 0.00% 6 Missing ⚠️
src/WopiHost.Core/WopiCoreBuilderExtensions.cs 0.00% 4 Missing ⚠️
...Security/Authorization/WopiAuthorizationHandler.cs 0.00% 2 Missing ⚠️
...WopiHost.FileSystemProvider/WopiSecurityHandler.cs 0.00% 2 Missing ⚠️
src/WopiHost.Abstractions/IWopiLockProvider.cs 75.00% 1 Missing ⚠️
.../WopiHost.Core/Controllers/ContainersController.cs 0.00% 1 Missing ⚠️
...ost.Core/Controllers/WopiBootstrapperController.cs 0.00% 1 Missing ⚠️
src/WopiHost.Core/FileExtensions.cs 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   17.78%   23.26%   +5.48%     
==========================================
  Files          47       48       +1     
  Lines         973      993      +20     
  Branches       90      102      +12     
==========================================
+ Hits          173      231      +58     
+ Misses        786      733      -53     
- Partials       14       29      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petrsvihlik
Copy link
Owner

will be reviewed tonight...as well as the other one

Copy link
Owner

@petrsvihlik petrsvihlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all lgtm

@petrsvihlik petrsvihlik merged commit 71303e4 into petrsvihlik:master Feb 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants