Skip to content

build hhvm on trusty box #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2017
Merged

build hhvm on trusty box #177

merged 1 commit into from
Jun 26, 2017

Conversation

fbourigault
Copy link
Contributor

@Nyholm
Copy link
Member

Nyholm commented Jun 26, 2017

You need to remove hhvm on line 14

@fbourigault
Copy link
Contributor Author

Build is now green! I just fixed one test which was probably working for php because of a mocking side-effect.

Nyholm
Nyholm approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@Nyholm Nyholm merged commit a131e38 into php-http:master Jun 26, 2017
@fbourigault fbourigault deleted the fix-hhvm-build branch June 26, 2017 15:24
@fbourigault fbourigault mentioned this pull request Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbourigault @Nyholm