Skip to content

Improve tests no2 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2018
Merged

Improve tests no2 #51

merged 1 commit into from
Dec 27, 2018

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Dec 25, 2018

  • Remove HHVM from tests.
  • Use createMock everywhere.
  • Unrelated but in order not to create another PR I added some files to .gitattibute file.

@gmponos
Copy link
Contributor Author

gmponos commented Dec 25, 2018

@dbu sorry for that.. I should have added these to previous PR about set method.. but I just saw these.

dbu
dbu approved these changes Dec 27, 2018
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot! no need to be sorry, small separate PRs are easier to review than large ones with unrelated things mixed together.

@dbu dbu merged commit cc9e183 into php-http:master Dec 27, 2018
@gmponos gmponos deleted the improve_tests_2 branch December 27, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmponos @dbu