Skip to content

Handle null explicitly for max body length of FullHttpMessageFormatter #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2019
Merged

Handle null explicitly for max body length of FullHttpMessageFormatter #112

merged 1 commit into from
Mar 8, 2019

Conversation

jdecool
Copy link
Contributor

@jdecool jdecool commented Mar 8, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

This PR is linked to php-http/HttplugBundle#322 to manage the null state explicitly for the $maxBodyLength parameter of Http\Message\Formatter\FullHttpMessageFormatter.

dbu
dbu approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, you even added a test!

@dbu dbu merged commit 31f25d6 into php-http:master Mar 8, 2019
@joelwurtz
Copy link
Member

Thanks @jdecool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdecool @joelwurtz @dbu