Skip to content

Added provide for php-http/message-factory-implementation #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2017
Merged

Added provide for php-http/message-factory-implementation #80

merged 2 commits into from
Jun 23, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 23, 2017

This will fix #75

@Nyholm Nyholm requested a review from dbu June 23, 2017 08:27
@Nyholm Nyholm mentioned this pull request Jun 23, 2017
Merged
dbu
dbu approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, here are the factories, not in the adapter. practically people could just depend on php-http/message then. but that is not future proof, so lets re-introduce this concept. can you also add a PR to the documentation so this is clear?

@sagikazarmark
Copy link
Member

AFAIK we decided not to do this because these interfaces are somewhat internal and the most important implementations are in message. But I am not specifically against it, so LGTM.

@sagikazarmark sagikazarmark merged commit aa70fb8 into master Jun 23, 2017
@sagikazarmark sagikazarmark deleted the issue-75 branch June 23, 2017 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

+1 more reviewer

@fbourigault fbourigault fbourigault approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing provides in composer.json file
4 participants
@Nyholm @sagikazarmark @dbu @fbourigault