improve ignores I.

php-lock · Dec 3, 2024 · 7b4427a · 7b4427a
1 parent 72e3aac
commit 7b4427a
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/src/mutex/PgAdvisoryLockMutex.php b/src/mutex/PgAdvisoryLockMutex.php
@@ -30,7 +30,7 @@ public function __construct(\PDO $PDO, string $name)
 
         $hashed_name = hash('sha256', $name, true);
 
-        if ($hashed_name === false) { // @phpstan-ignore-line
+        if ($hashed_name === false) { // @phpstan-ignoreX
             throw new \RuntimeException('Unable to hash the key, sha256 algorithm is not supported.');
         }
 

diff --git a/src/util/Loop.php b/src/util/Loop.php
@@ -91,9 +91,9 @@ public function execute(callable $code)
         $deadline = microtime(true) + $this->timeout;
 
         $result = null;
-        for ($i = 0; $this->looping && microtime(true) < $deadline; ++$i) { // @phpstan-ignore-line
+        for ($i = 0; $this->looping && microtime(true) < $deadline; ++$i) { // @phpstan-ignoreX
             $result = $code();
-            if (!$this->looping) { // @phpstan-ignore-line
+            if (!$this->looping) { // @phpstan-ignoreX
                 // The $code callback has called $this->end() and the lock has been acquired.
 
                 return $result;

diff --git a/tests/mutex/FlockMutexTest.php b/tests/mutex/FlockMutexTest.php
@@ -25,7 +25,7 @@ protected function setUp(): void
         parent::setUp();
 
         $this->file = tempnam(sys_get_temp_dir(), 'flock-');
-        $this->mutex = Liberator::liberate(new FlockMutex(fopen($this->file, 'r'), 1)); // @phpstan-ignore-line
+        $this->mutex = Liberator::liberate(new FlockMutex(fopen($this->file, 'r'), 1)); // @phpstan-ignoreX
     }
 
     protected function tearDown(): void
@@ -40,7 +40,7 @@ protected function tearDown(): void
      */
     public function testCodeExecutedOutsideLockIsNotThrown(int $strategy)
     {
-        $this->mutex->strategy = $strategy; // @phpstan-ignore-line
+        $this->mutex->strategy = $strategy; // @phpstan-ignoreX
 
         self::assertTrue($this->mutex->synchronized(static function (): bool {
             usleep(1100 * 1000);
@@ -60,7 +60,7 @@ public function testTimeoutOccurs(int $strategy)
         $another_resource = fopen($this->file, 'r');
         flock($another_resource, \LOCK_EX);
 
-        $this->mutex->strategy = $strategy; // @phpstan-ignore-line
+        $this->mutex->strategy = $strategy; // @phpstan-ignoreX
 
         try {
             $this->mutex->synchronized(
@@ -88,7 +88,7 @@ public function testNoTimeoutWaitsForever()
         $another_resource = fopen($this->file, 'r');
         flock($another_resource, \LOCK_EX);
 
-        $this->mutex->strategy = FlockMutex::STRATEGY_BLOCK; // @phpstan-ignore-line
+        $this->mutex->strategy = FlockMutex::STRATEGY_BLOCK; // @phpstan-ignoreX
 
         $timebox = new PcntlTimeout(1);
         $timebox->timeBoxed(function () {

diff --git a/tests/mutex/MutexConcurrencyTest.php b/tests/mutex/MutexConcurrencyTest.php
@@ -235,15 +235,15 @@ public static function provideExecutionIsSerializedWhenLockedCases(): iterable
             'flockWithTimoutPcntl' => [static function ($timeout = 3) use ($filename): Mutex {
                 $file = fopen($filename, 'w');
                 $lock = Liberator::liberate(new FlockMutex($file, $timeout));
-                $lock->strategy = FlockMutex::STRATEGY_PCNTL; // @phpstan-ignore-line
+                $lock->strategy = FlockMutex::STRATEGY_PCNTL; // @phpstan-ignoreX
 
                 return $lock->popsValue();
             }],
 
             'flockWithTimoutBusy' => [static function ($timeout = 3) use ($filename): Mutex {
                 $file = fopen($filename, 'w');
                 $lock = Liberator::liberate(new FlockMutex($file, $timeout));
-                $lock->strategy = FlockMutex::STRATEGY_BUSY; // @phpstan-ignore-line
+                $lock->strategy = FlockMutex::STRATEGY_BUSY; // @phpstan-ignoreX
 
                 return $lock->popsValue();
             }],

diff --git a/tests/mutex/MutexTest.php b/tests/mutex/MutexTest.php
@@ -53,15 +53,15 @@ public function provideMutexFactoriesCases(): iterable
             'flockWithTimoutPcntl' => [static function (): Mutex {
                 $file = fopen(vfsStream::url('test/lock'), 'w');
                 $lock = Liberator::liberate(new FlockMutex($file, 3));
-                $lock->strategy = FlockMutex::STRATEGY_PCNTL; // @phpstan-ignore-line
+                $lock->strategy = FlockMutex::STRATEGY_PCNTL; // @phpstan-ignoreX
 
                 return $lock->popsValue();
             }],
 
             'flockWithTimoutBusy' => [static function ($timeout = 3): Mutex {
                 $file = fopen(vfsStream::url('test/lock'), 'w');
                 $lock = Liberator::liberate(new FlockMutex($file, 3));
-                $lock->strategy = FlockMutex::STRATEGY_BUSY; // @phpstan-ignore-line
+                $lock->strategy = FlockMutex::STRATEGY_BUSY; // @phpstan-ignoreX
 
                 return $lock->popsValue();
             }],