Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect binding-style from both soap:operation and soap:binding #44

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

veewee
Copy link
Member

@veewee veewee commented Feb 7, 2025

Q A
Type improvement
BC Break no
Fixed issues

Summary

Fixes phpro/soap-client#567

This PR reads the style from both soap:binding and soap:operation tags.
Rules for detecting the style:

  • BindingStyle = operation.style ?? binding.style ?? "document";

@veewee veewee merged commit 4a5b325 into php-soap:main Feb 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect XML Generation
1 participant