Skip to content

Fix GH-17101 (AST->string does not reproduce constructor property promotion correctly) #17133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Fix GH-17101 (AST->string does not reproduce constructor property promotion correctly) #17133

wants to merge 5 commits into from

Conversation

nielsdos
Copy link
Member

Several bugs, see individual commits

@nielsdos nielsdos linked an issue Dec 12, 2024 that may be closed by this pull request
AST->string does not reproduce constructor property promotion correctly #17101
Closed
@nielsdos nielsdos requested a review from iluuu1994 December 12, 2024 20:59
iluuu1994
iluuu1994 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nielsdos
Copy link
Member Author

Fixed via 6f41bfd..97f44b7

@nielsdos nielsdos closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AST->string does not reproduce constructor property promotion correctly
2 participants
@nielsdos @iluuu1994