Drop FIXME in pcntl_signal_dispatch() #18633
Merged
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment used to be true when the zvals were heap allocated and the destruction must be done properly. However, it _is_ done properly nowadays by calling zval_ptr_dtor(). Furthermore, since call_user_function() always initializes the return value with UNDEF, we can remove the ZVAL_NULL() line.
devnexen
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment used to be true when the zvals were heap allocated and the destruction must be done properly. However, it is done properly nowadays by calling zval_ptr_dtor(). Furthermore, since call_user_function() always initializes the return value with UNDEF, we can remove the ZVAL_NULL() line.