-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Zend: Warn when destructuring non-array values #19439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
14aa389
to
037487d
Compare
847ad5f
to
f1bf73d
Compare
@arnaud-lb could you point me towards the correct direction in regards to the CI failure as it seems related to opcache :-/ |
@Girgias the output of |
f1bf73d
to
2bd54ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Merge code blocks, remove relative paths for headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RM approval 👍
RFC: https://wiki.php.net/rfc/warnings-php-8-5#destructuring_non-array_values