Skip to content

Commit

Permalink
Fix connections sticking around indefinitely
Browse files Browse the repository at this point in the history
For some reason it only affects the extension host socket (something to
do with passing it via IPC?) but I changed both just to be sure.

Fixes coder#1795.
  • Loading branch information
code-asher committed Jun 30, 2020
1 parent a942531 commit ebef18d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ci/dev/vscode.patch
Original file line number Diff line number Diff line change
Expand Up @@ -1811,7 +1811,7 @@ index 0000000000..1166835371
+}
diff --git a/src/vs/server/node/connection.ts b/src/vs/server/node/connection.ts
new file mode 100644
index 0000000000..23934687de
index 0000000000..36e80fb696
--- /dev/null
+++ b/src/vs/server/node/connection.ts
@@ -0,0 +1,157 @@
Expand Down Expand Up @@ -1878,7 +1878,7 @@ index 0000000000..23934687de
+ protected doDispose(): void {
+ this.protocol.sendDisconnect();
+ this.protocol.dispose();
+ this.protocol.getSocket().end();
+ this.protocol.getUnderlyingSocket().destroy();
+ }
+
+ protected doReconnect(socket: ISocket, buffer: VSBuffer): void {
Expand All @@ -1905,7 +1905,7 @@ index 0000000000..23934687de
+ if (this.process) {
+ this.process.kill();
+ }
+ this.protocol.getSocket().end();
+ this.protocol.getUnderlyingSocket().destroy();
+ }
+
+ protected doReconnect(socket: ISocket, buffer: VSBuffer): void {
Expand Down

0 comments on commit ebef18d

Please sign in to comment.