Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create copy-content-to-clipboard.md #504

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

duran-0519
Copy link

No description provided.

@duran-0519
Copy link
Author

new javascript code

Copy link
Contributor

@elkarouani elkarouani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dxl519, you can do this suggested changes :

  • For the solution of 'Fahrenheit to Celsius', I think you should move the .md file to the number directory.
  • The same for the solution of 'Randomly generated string', you can move it to the number directory

Helpful snippets, thanks bro 👍

@duran-0519
Copy link
Author

Ok, thank you very much for your suggestion, I will modify it now.

@duran-0519
Copy link
Author

Hi @dxl519, you can do this suggested changes :

  • For the solution of 'Fahrenheit to Celsius', I think you should move the .md file to the number directory.
  • The same for the solution of 'Randomly generated string', you can move it to the number directory

Helpful snippets, thanks bro 👍

@elkarouani
Do I need to resubmit a new pull request? Or you can change the Fahrenheit to Celsius solution to another folder at the current request. Forgive me, I don't know how to use github.

@duran-0519
Copy link
Author

嗨@dxl519,您可以执行以下建议更改:

  • 对于'Fahrenheit to Celsius'的解决方案,我认为你应该将.md文件移动到数字目录。
  • '随机生成的字符串'的解决方法相同,可以将其移至数字目录

有用的片段,谢谢兄弟👍
@elkarouani,I've made changes, see the commit on February 14, 2022

Copy link
Contributor

@elkarouani elkarouani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, still at least one change you can do :

  • For the solution of 'Randomly generated string', you can move it to string folder, because it seems that it returns a string not a number

@duran-0519
Copy link
Author

duran-0519 commented Feb 15, 2022

That's great, still at least one change you can do :

  • For the solution of 'Randomly generated string', you can move it to string folder, because it seems that it returns a string not a number

@elkarouani,I've made changes, see the commit on February 15, 2022.I will submit more code

@duran-0519 duran-0519 marked this pull request as draft February 26, 2022 04:29
@duran-0519 duran-0519 marked this pull request as ready for review February 26, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants