Skip to content

Commit

Permalink
iotune: reduce dependency on seastar core
Browse files Browse the repository at this point in the history
Do not bring in the reactor through its headers. Also, do not compile
the other seastar objects in, except for the resource.cc file - which is
fairly independent of the rest anyway.

The end goal is to break iotune's dependency on the seastar memory
allocator.

Signed-off-by: Glauber Costa <[email protected]>
  • Loading branch information
Glauber Costa committed Oct 12, 2016
1 parent c813f26 commit 3b8c270
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion apps/iotune/iotune.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,16 @@
#include <wordexp.h>
#include <boost/thread/barrier.hpp>
#include <boost/filesystem.hpp>
#include <boost/range/irange.hpp>
#include <boost/program_options.hpp>
#include <mutex>
#include <deque>
#include <queue>
#include <fstream>
#include "core/sstring.hh"
#include "core/posix.hh"
#include "core/reactor.hh"
#include "core/resource.hh"
#include "core/aligned_buffer.hh"
#include "util/defer.hh"

using namespace std::chrono_literals;
Expand Down
2 changes: 1 addition & 1 deletion configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ def have_xen():
'tests/fair_queue_test': ['tests/fair_queue_test.cc'] + core + boost_test_lib,
'apps/seawreck/seawreck': ['apps/seawreck/seawreck.cc', 'http/http_response_parser.rl'] + core + libnet,
'apps/fair_queue_tester/fair_queue_tester': ['apps/fair_queue_tester/fair_queue_tester.cc'] + core,
'apps/iotune/iotune': ['apps/iotune/iotune.cc', 'apps/iotune/fsqual.cc'] + core,
'apps/iotune/iotune': ['apps/iotune/iotune.cc', 'apps/iotune/fsqual.cc'] + ['core/resource.cc'],
'tests/blkdiscard_test': ['tests/blkdiscard_test.cc'] + core,
'tests/sstring_test': ['tests/sstring_test.cc'] + core,
'tests/unwind_test': ['tests/unwind_test.cc'] + core,
Expand Down

0 comments on commit 3b8c270

Please sign in to comment.