Skip to content

Commit

Permalink
revert torch 2.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@acatav
acatav committed Apr 11, 2023
1 parent 9b71f36 commit e8d2f14
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,12 @@ packages = [{include = "pinecone_text"}]

[tool.poetry.dependencies]
python = ">=3.8,<4.0"
torch = "2.0.0"
torch = "^1.13.1"
transformers = "^4.26.1"
sentence-transformers = "^2.0.0"
wget = "^3.2"
mmh3 = "^3.1.0"
nltk = "^3.6.5"
numpy = "^1.21.2"

[tool.poetry.group.dev]
optional = true
Expand Down

2 comments on commit e8d2f14

@gitmj
Copy link

@gitmj gitmj commented on e8d2f14 Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific problem you faced with torch = "2.0.0" ? Perhaps, torch = ">=1.13.1" to allow people to use torch 2.0 while still supporting older versions.

Right now when I try to install 'pip install pinecone-text', it's throwing compatibility error:

ERROR: Cannot install pinecone-text==0.1.0, pinecone-text==0.1.1 and pinecone-text==0.4.2 because these package versions have conflicting dependencies.

The conflict is caused by:
pinecone-text 0.4.2 depends on torch<2.0.0 and >=1.13.1
pinecone-text 0.1.1 depends on torch<2.0.0 and >=1.13.1
pinecone-text 0.1.0 depends on torch<2.0.0 and >=1.13.1

@gitmj
Copy link

@gitmj gitmj commented on e8d2f14 Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I made the proposed change, i.e. torch = ">=1.13.1", in my local repo of pinecone-text so that pinecone-text could work with torch 2.0.1 and it seems to be working fine. I am using pinecone-text bm25 encoder like this : bm25.encode_queries(user_msg)

So, proposed changes seems to be safe, at least from encoding perspective.

Please sign in to comment.