fix mobile preview & edit links #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on mobile preview & edit don't work They just diplay the HTML view and they have large paddings. mobile detection for Google Docs is not based on screen size. It must be based on either device or touchscreen detection. Here we do touch screen detection. On a touch screen, use the Google Docs link. If the user has the Google app installed this should open in the app.
gregwebs
force-pushed
the
mobile-preview-edit
branch
from
42f45aa to
88e0da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on mobile preview & edit don't work
They just diplay the HTML view and they have large paddings.
mobile detection for Google Docs is not based on screen size.
It must be based on either device or touchscreen detection.
Here we do touch screen detection.
On a touch screen, use the Google Docs link.
If the user has the Google app installed this should open in the app.
addresses #136. If this works properly we can address the rest of the items in that issue with this.