Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for script token expiry date #1739

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Conversation

tylerwowen
Copy link
Contributor

@tylerwowen tylerwowen commented Nov 1, 2024

This pull request includes changes to introduce token expiry checks and update user notifications in the deploy-board and deploy-service modules. The most important changes include adding a warning message for deprecated script tokens, implementing token expiry logic, and updating tests to cover the new functionality.

User Interface Updates:

Screenshot 2024-11-01 at 14 23 09 Screenshot 2024-11-01 at 15 30 40 Screenshot 2024-11-01 at 14 33 14

Backend Changes:

Testing Updates:

Launched Teletraan service locally and confirmed that all 3 cases are working as expected

  1. checkTokenExpiry not set
  2. checkTokenExpiry set to true
  3. checkTokenExpiry set to false

@tylerwowen tylerwowen requested a review from a team as a code owner November 1, 2024 19:00
@github-actions github-actions bot added the deploy-service Includes changes to deploy-service label Nov 1, 2024
@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Nov 1, 2024
@tylerwowen tylerwowen merged commit e8dae0a into master Nov 6, 2024
6 checks passed
@tylerwowen tylerwowen deleted the touyang/st_expiry branch November 6, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-board Includes changes to deploy-board deploy-service Includes changes to deploy-service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants