GCC: Fix bug when transitioning states #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 71.31% 72.07% +0.76%
==========================================
Files 80 80
Lines 4483 4484 +1
==========================================
+ Hits 3197 3232 +35
+ Misses 1153 1117 -36
- Partials 133 135 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sterlingdeng
force-pushed
the
sdeng/gcc_fix_rate_controller
branch
2 times, most recently
from
aecb15e to
6da699f
Compare
This fixes an issue described in pion#271. The original implementation did not transition rate controller states properly.
sterlingdeng
force-pushed
the
sdeng/gcc_fix_rate_controller
branch
from
6da699f to
577d59e
Compare
sterlingdeng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation did not transition rate controller states properly. The initial state of the transition was incorrect because it did not use or record the previous state of the rate controller. This
lastStatefield was available but never used, which indicates that it probably was originally planned for this use case but might have slipped through the cracks during the initial implementation.See GCC RFC for details.
Description
Reference issue
Fixes #271