Fixing wordlist creds parsing (threat9#609)

* Fixing wordlist creds parsing * Pinning requests package because of URL normalization in new version
pirenga · Aug 31, 2019 · b292f4e · b292f4e
1 parent e781f49
commit b292f4e
Show file tree

Hide file tree

Showing 10 changed files with 10 additions and 10 deletions.
diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -1,5 +1,5 @@
 future
-requests
+requests==2.21.0
 paramiko
 pysnmp==4.4.6
 pycryptodome

diff --git a/requirements.txt b/requirements.txt
@@ -1,5 +1,5 @@
 future
-requests
+requests==2.21.0
 paramiko
 pysnmp==4.4.6
 pycryptodome
diff --git a/routersploit/modules/creds/cameras/acti/webinterface_http_form_default_creds.py b/routersploit/modules/creds/cameras/acti/webinterface_http_form_default_creds.py
@@ -48,7 +48,7 @@ def attack(self):
     def target_function(self, running, creds):
         while running.is_set():
             try:
-                username, password = creds.next().split(":")
+                username, password = creds.next().split(":", 1)
 
                 data = {
                     "LOGIN_ACCOUNT": username,

diff --git a/routersploit/modules/creds/cameras/basler/webinterface_http_form_default_creds.py b/routersploit/modules/creds/cameras/basler/webinterface_http_form_default_creds.py
@@ -48,7 +48,7 @@ def attack(self):
     def target_function(self, running, creds):
         while running.is_set():
             try:
-                username, password = creds.next().split(":")
+                username, password = creds.next().split(":", 1)
 
                 data = {
                     "Auth.Username": username,

diff --git a/routersploit/modules/creds/generic/ftp_default.py b/routersploit/modules/creds/generic/ftp_default.py
@@ -49,7 +49,7 @@ def attack(self):
     def target_function(self, running, data):
         while running.is_set():
             try:
-                username, password = data.next().split(":")
+                username, password = data.next().split(":", 1)
             except StopIteration:
                 break
             else:

diff --git a/routersploit/modules/creds/generic/http_basic_digest_default.py b/routersploit/modules/creds/generic/http_basic_digest_default.py
@@ -56,7 +56,7 @@ def attack(self):
     def target_function(self, running, data):
         while running.is_set():
             try:
-                username, password = data.next().split(":")
+                username, password = data.next().split(":", 1)
 
                 if self.auth_type == "digest":
                     auth = HTTPDigestAuth(username, password)

diff --git a/routersploit/modules/creds/generic/ssh_default.py b/routersploit/modules/creds/generic/ssh_default.py
@@ -50,7 +50,7 @@ def attack(self):
     def target_function(self, running, data):
         while running.is_set():
             try:
-                username, password = data.next().split(":")
+                username, password = data.next().split(":", 1)
                 ssh_client = self.ssh_create()
                 if ssh_client.login(username, password):
                     if self.stop_on_success:

diff --git a/routersploit/modules/creds/generic/telnet_default.py b/routersploit/modules/creds/generic/telnet_default.py
@@ -50,7 +50,7 @@ def attack(self):
     def target_function(self, running, data):
         while running.is_set():
             try:
-                username, password = data.next().split(":")
+                username, password = data.next().split(":", 1)
                 telnet_client = self.telnet_create()
                 if telnet_client.login(username, password, retries=3):
                     if self.stop_on_success:

diff --git a/routersploit/modules/creds/routers/mikrotik/api_ros_default_creds.py b/routersploit/modules/creds/routers/mikrotik/api_ros_default_creds.py
@@ -47,7 +47,7 @@ def attack(self):
     def target_function(self, running, creds):
         while running.is_set():
             try:
-                username, password = creds.next().split(":")
+                username, password = creds.next().split(":", 1)
 
                 tcp_client = self.tcp_create()
                 tcp_sock = tcp_client.connect()

diff --git a/routersploit/modules/creds/routers/pfsense/webinterface_http_form_default_creds.py b/routersploit/modules/creds/routers/pfsense/webinterface_http_form_default_creds.py
@@ -45,7 +45,7 @@ def attack(self):
             print_error("Credentials not found")
 
     def target_function(self, data):
-        username, password = data.split(":")
+        username, password = data.split(":", 1)
 
     def check(self):
         response = self.http_request(