Destroy application on unmount #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trezy
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f3cc9e5:
|
lunarraid
reviewed
Sep 3, 2024
|
I've tested this PR in a personal project and it handles the issues I was facing, it works well for me! |
|
Really looking forward v8 beeing a tad more stable; i'm also suffering from this; any way to help move this branch/the project forward ? happy to help |
|
@rvion this comment will provide more context. |
Signed-off-by: Trezy <[email protected]>
Signed-off-by: Trezy <[email protected]>
Signed-off-by: Trezy <[email protected]>
trezy
deleted the
521-bug-v8-memoized-component-renders-after-being-unmounted
branch
|
🎉 This PR is included in version 8.0.0-beta.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
<Application>will now be destroyed when unmounted.Pre-Merge Checklist
npm run lint)npm run test)