Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add usage instructions for wiby close-pr command #149

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

bjohansebas
Copy link
Contributor

Run npm run generate-docs, maybe we could create a workflow to open a PR every time the options are updated.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@bjohansebas
Copy link
Contributor Author

this package doesn't even work for Node 12 anymore, maybe we should stop supporting those versions of Node.js?

And the errors in the CI for Node LTS should be fixed with #148.

@ljharb
Copy link
Member

ljharb commented Feb 15, 2025

I think it's a good idea to get the tests passing on all supported node lines before dropping support for any of them.

@bjohansebas
Copy link
Contributor Author

Yep, although well, this is not the responsibility of this PR

@ljharb ljharb merged commit 3b650fd into pkgjs:main Feb 19, 2025
8 checks passed
@bjohansebas bjohansebas deleted the update-docs branch February 19, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants