Update export.py #78
Open
Update export.py #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changing `fieldnames` to save as an parameter.
Overhaul of this file. Since this repo is inactive, I am making many changes to my branch at once as it best suits my needs.
1. Error Handling:
Suppresses unnecessary logging of failed downloads within download_single.
Handles 404 errors gracefully by returning False and potentially logging the error elsewhere (as specified in your requirement).
Logs errors from the download process using a placeholder comment # Logging is assumed to be handled elsewhere. You'll need to integrate your preferred logging mechanism with this code.
2. Progress Bar:
Uses tqdm_asyncio for an optional progress bar during download.
Disables the progress bar if the loglevel is set to ERROR or CRITICAL.
3. Code Clarity:
Improved comments to explain function arguments and behavior.
Removed unnecessary imports.
4. Functionality:
Maintains the core functionality of downloading items from a generator (either synchronous or asynchronous).
Added support for random subsets using the random_subsets argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying
fieldnamesto become a parameter.