skip not existing order item

plentymarkets · Feb 13, 2020 · 9260af9 · 9260af9
1 parent c94e165
commit 9260af9
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/Adapter/PlentymarketsAdapter/ResponseParser/Order/OrderResponseParser.php b/Adapter/PlentymarketsAdapter/ResponseParser/Order/OrderResponseParser.php
@@ -720,6 +720,7 @@ private function getOrderItems(array $entry): array
         $result = [];
 
         foreach ($entry['orderItems'] as $item) {
+
             $number = $this->getNumberFromVariation($item['itemVariationId']);
 
             if (empty($number)) {
@@ -759,20 +760,15 @@ private function getOrderItemPrice(array $item): float
         return $price;
     }
 
-    /**
-     * @param $variationId
-     *
-     * @return string
-     */
-    private function getNumberFromVariation($variationId): string
+    private function getNumberFromVariation($variationId): ?string
     {
         static $variations;
 
         if (!isset($variations[$variationId])) {
             $response = $this->client->request('GET', 'items/variations', ['id' => $variationId]);
 
             if (empty($response)) {
-                return '';
+                return null;
             }
 
             $variation = array_shift($response);